-
Notifications
You must be signed in to change notification settings - Fork 1
tc notifications #547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
tc notifications #547
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR introduces a broadcasting system for push notifications using a job queue architecture. The changes add the ability to broadcast events to user relays and send push notifications based on event filters.
Key Changes
- Integrates River job queue (rq) for asynchronous processing of broadcast and notification tasks
- Adds broadcaster functionality to forward events to user-specific relay URLs
- Refactors rq.Config to embed query.Config, consolidating database configuration
- Exports BroadcastTo method and removes unused generic type parameter from MustNewClient
Reviewed changes
Copilot reviewed 19 out of 20 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| server/broadcaster/broadcast.go | Exports BroadcastTo method and removes unused url parameter from newInitAuthEvent |
| rq/client.go | Embeds query.Config in Config struct and removes generic type parameter from MustNewClient |
| rq/client_test.go | Updates test to use new embedded Config structure with query.Config |
| push-notifications/pushnotifications.go | Adds broadcasting infrastructure with job workers, new NotificationTypePost, and ephemeral event handling |
| push-notifications/stats.go | Reorders struct fields (non-functional change) |
| push-notifications/broadcaster_*.go | New worker files for relay finding, broadcasting, and user notification processing |
| push-notifications/*_test.go | Adds test helpers, parallel test support, and changes DefaultTranslations to defaultTranslations (unexported) |
| model/event.go | Adds Hash() method using xxh3 for generating batch IDs |
| cmd/subzero-ion-connect*.go | Initializes rq client and passes it to pushnotifications.MustInit |
| go.mod/go.sum | Updates dependencies for gdu and google.golang.org packages |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 20 out of 21 changed files in this pull request and generated 15 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
83971e7 to
3ddebc4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 34 out of 35 changed files in this pull request and generated 10 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
129bb43 to
7479990
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 34 out of 34 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.