Skip to content

fix: handle null response case for ohlcv get request #3326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ice-phobos wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: handle null response case for ohlcv get request #3326

ice-phobos wants to merge 1 commit into from
+3 −2

Conversation

@ice-phobos
Copy link
Contributor

@ice-phobos ice-phobos commented Feb 9, 2026 •
edited
Loading

Description

  • Handle null OHLCV response in repository by returning empty list so chart shows flat-line empty state instead of error.

Additional info

  • Also this makes use cached candles when changing timeframe so the chart keeps showing the previous interval’s data with grey loading style instead of switching to the demo placeholder and flickering

Task ID

ION-5495

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Refactoring
  • Documentation
  • Chore

@ice-phobos ice-phobos marked this pull request as ready for review February 9, 2026 20:19
@ice-phobos ice-phobos requested review from a team as code owners February 9, 2026 20:19
@ice-phobos ice-phobos enabled auto-merge (squash) February 9, 2026 20:19
@ice-morpheus ice-morpheus force-pushed the fix/ohlcv-null-response-empty-list branch from 2f570d0 to 29171d0 Compare February 9, 2026 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ice-linus ice-linus ice-linus approved these changes

At least 3 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ice-phobos @ice-linus