fix: improve caching of useWatchWhenVisible #3305
Open
+34
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to improve caching in the useWatchWhenVisible hook to prevent UI flickering when providers reinitialize after being inactive. The changes add logic to retain cached AsyncValue data when the provider briefly returns loading or null states during reinitialization. Additionally, it includes UI improvements to the tokenized community page.
Changes:
- Enhanced
useWatchWhenVisiblehook with smart caching logic to avoid showing degraded states (loading/null) when returning to a visible route - Excluded twitter tokens from showing duplicate titles in the header
- Added text overflow handling and removed conditional padding for better UI consistency
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/app/hooks/use_watch_when_visible.dart | Added AsyncValue-aware caching logic to preserve last good state during provider reinitialization, preventing flickering |
| lib/app/features/tokenized_communities/views/pages/tokenized_community_page.dart | Excluded twitter token type from title display, added ellipsis for overflow protection, and removed conditional padding for consistency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ice-endymion
previously approved these changes
Feb 9, 2026
ice-evander
previously approved these changes
Feb 9, 2026
auto-merge was automatically disabled
February 9, 2026 10:25
Pull Request is not mergeable
ice-kreios
previously approved these changes
Feb 9, 2026
ice-damocles
dismissed stale reviews from ice-kreios, ice-evander, and ice-endymion
via
5bfccd5
ice-damocles
force-pushed
the
bugfix/use-when-active-cache-fixes
branch
from
c046f87 to
5bfccd5
Compare
ice-morpheus
force-pushed
the
bugfix/use-when-active-cache-fixes
branch
from
5bfccd5 to
152cec2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
useWatchWhenVisibleto avoid flickering of the statesTask ID
ION-5434
ION-5419
Type of Change