Open
Conversation
PersonTest.java , Tests zu isTeen() geschrieben
UserValidatorTest + UserControllerTest 2. Version
ideadapt
reviewed
Nov 17, 2021
Contributor
ideadapt
left a comment
ideadapt
left a comment
There was a problem hiding this comment.
Bis auf ein par Kleinigkeiten schaut das super aus. Glaube du hast das Prinzip verstanden!
| UserValidator mockitoUv = mock(UserValidator.class); | ||
| UserController ctrl = new UserController(mockitoDb, mockitoUv); | ||
| //Wenn methoden isValidUsername && doesUsernameExist.thenReturn (Boolean wert) | ||
| when(mockitoUv.isValidUsername(anyString())).thenReturn(false); |
Contributor
There was a problem hiding this comment.
Testname müsste dann mit withInvalid beginnen ;)
| UserController ctrl = new UserController(mockitoUv); | ||
| User user = new User("Martin"); | ||
| //Mockito Returnwert setzen | ||
| doReturn(true).when(mockitoUv).doesUsernameExist("Martin"); |
Contributor
There was a problem hiding this comment.
Testname müsste dann mit withValidExistingUsername_ starten ;)
| //Act | ||
| ctrl.create(user); | ||
| boolean userInDB; | ||
| userInDB = mockDb.getUsers() == mockDb.users; |
Contributor
There was a problem hiding this comment.
getUsers und users ist ja das gleiche objekt. unabhängig davon wieviele elemente in der liste sind, der vergleich ist immer true :)
| // Is teen if Age 12 <= && >=18 | ||
| Period age = getAge(); | ||
| years = age.getYears(); | ||
| if (years >= 12 && years <= 18){ |
Contributor
There was a problem hiding this comment.
teen kommt von "thirTEEN" und nicht von "twelve" ;)
Nach review überarbeitet :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Danke für das Mail und die überarbeiteten Tests :) Hier ist mein zweiter Versuch