-
Notifications
You must be signed in to change notification settings - Fork 2
remove npm provenance #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates the npm publish GitHub Actions workflow to stop using the --provenance flag, addressing publish failures while keeping public access and authentication unchanged. Flow diagram for updated npm publish pipeline without provenancegraph TD
A["Workflow Trigger (e.g., push or release)"] --> B["Start npm-publish Job"]
B --> C["Checkout repository"]
C --> D["Setup Node.js environment"]
D --> E["Install dependencies with yarn"]
E --> F["Build project with yarn build"]
F --> G["Set NODE_AUTH_TOKEN from NPM_TOKEN secret"]
G --> H["Run npm publish --access public"]
H --> I["Package published to npm Registry"]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- Consider adding a brief comment in the workflow near the publish step explaining why the --provenance flag is disabled, so future maintainers understand this is intentional and related to current pipeline 404 issues.
- You might want to gate the use of --provenance behind an input, env var, or matrix option so it can be re-enabled or experimented with in specific branches or workflows without another code change.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider adding a brief comment in the workflow near the publish step explaining why the --provenance flag is disabled, so future maintainers understand this is intentional and related to current pipeline 404 issues.
- You might want to gate the use of --provenance behind an input, env var, or matrix option so it can be re-enabled or experimented with in specific branches or workflows without another code change.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes the --provenance flag from the npm publish command in the GitHub Actions workflow to work around 404 errors encountered during publishing.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| - name: Publish to npm | ||
| run: npm publish --provenance --access public | ||
| run: npm publish --access public |
Copilot
AI
Nov 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since --provenance has been removed from the publish command, the id-token: write permission on line 12 is no longer necessary. Consider removing it from the permissions block to follow the principle of least privilege, as it's specifically required for npm provenance publishing.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13 +/- ##
==========================================
+ Coverage 53.26% 60.19% +6.92%
==========================================
Files 51 51
Lines 2050 2050
Branches 512 524 +12
==========================================
+ Hits 1092 1234 +142
+ Misses 956 816 -140
+ Partials 2 0 -2
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Would rather publish with provenance but am seeing 404s on publish through the pipelines, for a package that is absolutely in the registry.
Summary by Sourcery
CI: