-
Notifications
You must be signed in to change notification settings - Fork 2
Node 20 and added test coverage #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR downgrades the project’s required Node.js version from 22 to 20 across CI, publishing workflows, and package metadata, and introduces a suite of new Jest tests for API and model layers to improve coverage. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR downgrades the minimum Node.js version requirement from 22 to 20 and adds comprehensive test coverage for models and API clients.
- Node.js version downgraded from 22 to 20 across all configuration files
- Added test coverage for 4 model classes (Pagination, Group, Dashboard, Artifact)
- Added test coverage for 6 API classes (RunApi, LoginApi, HealthApi, GroupApi, DashboardApi, ArtifactApi)
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updated Node.js engine requirement to >=20.0.0 |
| .nvmrc | Changed Node version from 22 to 20 |
| .github/workflows/build.yml | Updated Node version to 20 in all workflow jobs |
| .github/workflows/npm-publish.yml | Updated Node version to 20 in build and publish jobs |
| .gitignore | Added coverage-output.txt to ignored files |
| src/models/tests/Pagination.test.ts | Added comprehensive tests for Pagination model including JSON conversion and round-trip testing |
| src/models/tests/Group.test.ts | Added comprehensive tests for Group model including JSON conversion and round-trip testing |
| src/models/tests/Dashboard.test.ts | Added comprehensive tests for Dashboard model including JSON conversion and round-trip testing |
| src/models/tests/Artifact.test.ts | Added comprehensive tests for Artifact model including JSON conversion and round-trip testing |
| src/apis/tests/RunApi.test.ts | Added extensive tests for RunApi including CRUD operations, authentication, and error handling |
| src/apis/tests/LoginApi.test.ts | Added extensive tests for LoginApi including authentication flows, account management, and error handling |
| src/apis/tests/HealthApi.test.ts | Added extensive tests for HealthApi including health checks, database health, and server info endpoints |
| src/apis/tests/GroupApi.test.ts | Added extensive tests for GroupApi including CRUD operations, authentication, and error handling |
| src/apis/tests/DashboardApi.test.ts | Added extensive tests for DashboardApi including CRUD operations, filtering, authentication, and error handling |
| src/apis/tests/ArtifactApi.test.ts | Added extensive tests for ArtifactApi including upload, download, view, delete operations, and error handling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
efab11b to
84a1611
Compare
84a1611 to
f18fddc
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (53.26%) is below the target coverage (85.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #11 +/- ##
===========================================
+ Coverage 25.41% 53.26% +27.85%
===========================================
Files 51 51
Lines 2050 2050
Branches 524 524
===========================================
+ Hits 521 1092 +571
+ Misses 1529 956 -573
- Partials 0 2 +2
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Summary by Sourcery
Align project and CI configuration with Node.js 20 and expand automated test coverage for core API and model components.
Build:
CI:
Tests:
Chores: