Skip to content

[patch] Make sls_channel optional #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
durera merged 1 commit into from
Dec 19, 2025
Merged

[patch] Make sls_channel optional #156

durera merged 1 commit into from
Dec 19, 2025

Conversation

@rawa-resul
Copy link
Contributor

@rawa-resul rawa-resul commented Dec 18, 2025 •
edited
Loading

Details

  • in pipelinerun-install.yml.j2
    • Made sls_channel optional because by default the sls role will use 3.x
    • Removed hardcoded sls_channel value because we can now pass this value in when in development mode

Testing

  • Tested various scenarios and installs via the CLI

@rawa-resul rawa-resul requested a review from a team as a code owner December 18, 2025 18:33
@durera durera added this pull request to the merge queue Dec 19, 2025
Merged via the queue into stable with commit 04767cb Dec 19, 2025
2 checks passed
@durera durera deleted the sls-rr branch December 19, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@durera durera durera approved these changes

@terc1997 terc1997 terc1997 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rawa-resul @durera @terc1997