Skip to content

Conversation

@Hardik-Prajapati-10
Copy link

@Hardik-Prajapati-10 Hardik-Prajapati-10 commented Dec 15, 2025

Issue

https://jsw.ibm.com/browse/MASCORE-10415

This change is part of enhancing Helm-based deployment capabilities by introducing a new custom resource and addon for better configuration management.

Description

Added Helm charts to define a new Custom Resource Definition (CRD): AppCfg.
Created a new GenericAddon to support dynamic configuration injection for applications.
Purpose: Enable flexible and centralized application configuration management through Kubernetes-native resources.
Impact: Improves maintainability and scalability of configuration handling across environments.

Test Results

Verified Helm chart installation on a local Kubernetes cluster.
Applied sample AppCfg resource and confirmed successful reconciliation by the GenericAddon.
Checked logs and resource status to ensure correct behavior.
Automated tests for CRD schema validation and Helm linting have passed.
image

⚠️ Notes for Reviewers

Copy link
Member

@whitfiea whitfiea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we adding a new MAS config type rather than using the genericaddon type that already exists? https://github.com/ibm-mas/gitops/tree/main/instance-applications/550-ibm-mas-addons-config/templates

Comment on lines 7 to 10
image:
repository: docker-na-proxy-rtp.artifactory.swg-devops.com/wiotp-docker-local/mas/graphite-configuration
tag: 1.7.35-pre.maxuif-3049-amd64
pullPolicy: Always
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need these image keys do we?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed.

@Hardik-Prajapati-10
Copy link
Author

Why are we adding a new MAS config type rather than using the genericaddon type that already exists? https://github.com/ibm-mas/gitops/tree/main/instance-applications/550-ibm-mas-addons-config/templates

We are introducing a new MAS config type because the way configurations are applied differs between on‑premises and SaaS environments. For on‑premises customers, we enable the Generic Addon screen directly in the Admin Dashboard. However, for SaaS customers, these configurations are applied through saas-envs, where we define the Maximo Application Configuration Framework details. This triggers the IBM toolchain, and ArgoCD then creates the corresponding Custom Resource (CR) in the cluster.

removed image tag from values.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants