OTP-1890 Fix "Short" Time Formats with AM/PM #348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…formats that use "AM" or "PM" can be compared regardless of which JDK formatted the string.
…gex strings to handle JDK differences, and now use DateTimeUtils#equalsAmPm() for the comparison.
…ateTimeUtils#equalsAmPm() to do a string comparison that will work for multiple JDKs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
devbefore they can be merged tomaster)Description
Short time format for locale
en_USgenerates a string designating hours and minutes, followed by an ASCII space and then "AM" or "PM". As of JDK 20, this space is replaced with narrow non-breaking space (NNBSP), so unit tests of strings containing these formatted times break.An earlier fix used regular expressions for both formats (e.g.
"[\\u202f ]PM") but this proved to be cumbersome and new unit tests were introduced with new hardcoded strings that also broke.This fix introduces a helper method to test formatted strings against hardcoded strings that include a NNBSP, with a backup retry with a string that has a regular ASCII space. Our unit test cases are easier to read and maintain.