Gmap pending fixes #303
Draft
Gmap pending fixes #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng device id, os, app version.
…to gmap-pending-fixes
…n reminder for one time trips
…ze JourneyState.*EpochMillis fields, so that unit tests can check whether these have been properly initialized in production code.
…eraryInternal() to avoid conditions where JourneyState.*EpochMillis values are uninitialized (set to 0).
…ons() method. - New testJourneyStateAfterOTPRequest() does NOT initialize these time values, so we can test that production code is doing so.
…rting transit leg stop.
…me to getNextOrClosestWaypoint.
… stop in vicinity.
…ransit and walk legs.
Replaced retired jdk version with amazon corretto
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
devbefore they can be merged tomaster)Description
Please explain the changes you made here and, if not immediately obvious from the code, how they resolve any referenced issues. Be sure to include all issues being resolved and any special configuration settings that are need for the software to run properly with these changes. If merging to master, please also list the PRs that are to be included.