Merge route networks #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binh-dam-ibigroup
requested changes
Aug 25, 2025
binh-dam-ibigroup
left a comment
binh-dam-ibigroup
left a comment
There was a problem hiding this comment.
route_networks.txt is exported incorrectly with the headers and content mixed up.
| /** | ||
| * Create a CSV row from original fields plus grouped (stop areas or route network) ids. | ||
| */ | ||
| protected static String createRow(CsvReader stopsReader, String ids, String[] csvFields) throws IOException { |
There was a problem hiding this comment.
Rename stopsReader to csvReader.
There was a problem hiding this comment.
Rename stopsReader back to csvReader.
Comment on lines
106
to
108
| "%s,%s%n", | ||
| String.join(",", CSV_FIELDS), | ||
| ROUTE_NETWORK_IDS_FIELD |
There was a problem hiding this comment.
Nit: Is there is a better way to concat one item to an array, or is a preset array or a list better for this purpose?
Author
There was a problem hiding this comment.
What about this? Not sure if it is any better: 82684ac
Author
There was a problem hiding this comment.
@binh-dam-ibigroup I've reverted these two changes. Is this good to go now?
|
|
||
| private static final String CSV_HEADER_FOR_EXPORT = String.format( | ||
| "%s", | ||
| String.join(",", CSV_FIELDS) |
binh-dam-ibigroup
approved these changes
Aug 26, 2025
binh-dam-ibigroup
left a comment
binh-dam-ibigroup
left a comment
There was a problem hiding this comment.
Latest changes seem to work. Consider including the refactors from #17.
refactor(Entity): Extract logic for printing col after existing ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
devbefore they can be merged tomaster)Description
Merge route networks into routes.