Additional feed summary params #634
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lidation and save to feed versi
…ed version and tests
josh-willis-arcadis
requested changes
Oct 14, 2025
src/main/java/com/conveyal/datatools/manager/models/FeedSourceSummary.java
Show resolved
Hide resolved
4 tasks
…includes error counts using exp
…sionSummary and created separat
…t if published feed version not
7 tasks
…ate to process all returned doc
…ion for feed sources Added sort
… obtain feed source error count
Contributor
binh-dam-ibigroup
left a comment
binh-dam-ibigroup
left a comment
There was a problem hiding this comment.
A few comments for now, but I sense that we will need to compute the publish status in datatools-server rather than the UI.
src/main/java/com/conveyal/datatools/manager/controllers/api/GtfsPlusController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/conveyal/datatools/manager/gtfsplus/GtfsPlusValidation.java
Show resolved
Hide resolved
src/main/java/com/conveyal/datatools/manager/gtfsplus/GtfsPlusValidation.java
Show resolved
Hide resolved
src/main/java/com/conveyal/datatools/manager/jobs/ValidateGtfsPlusFeedJob.java
Outdated
Show resolved
Hide resolved
src/main/java/com/conveyal/datatools/manager/models/FeedVersion.java
Outdated
Show resolved
Hide resolved
src/main/java/com/conveyal/datatools/manager/models/FeedVersionSummary.java
Outdated
Show resolved
Hide resolved
…exclude editor namespaces from
…tes): Data sanitizer updates sh
Newer reference is no longer needed
binh-dam-ibigroup
approved these changes
Dec 16, 2025
Contributor
binh-dam-ibigroup
left a comment
binh-dam-ibigroup
left a comment
There was a problem hiding this comment.
Nice changes, they work. A few more minor changes, but happy to pass this.
src/main/java/com/conveyal/datatools/manager/gtfsplus/GtfsPlusValidation.java
Outdated
Show resolved
Hide resolved
src/main/java/com/conveyal/datatools/manager/gtfsplus/GtfsPlusValidation.java
Outdated
Show resolved
Hide resolved
src/main/java/com/conveyal/datatools/manager/models/FeedSourceSummary.java
Outdated
Show resolved
Hide resolved
src/main/java/com/conveyal/datatools/manager/models/FeedSourceSummary.java
Outdated
Show resolved
Hide resolved
src/main/java/com/conveyal/datatools/manager/models/FeedSourceSummary.java
Outdated
Show resolved
Hide resolved
src/main/java/com/conveyal/datatools/manager/models/FeedSourceSummary.java
Show resolved
Hide resolved
src/test/java/com/conveyal/datatools/manager/controllers/api/FeedSourceControllerTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/conveyal/datatools/manager/controllers/api/FeedSourceControllerTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/conveyal/datatools/manager/controllers/api/FeedSourceControllerTest.java
Outdated
Show resolved
Hide resolved
src/main/java/com/conveyal/datatools/manager/models/PublishState.java
Outdated
Show resolved
Hide resolved
JymDyerIBI
approved these changes
Dec 18, 2025
Contributor
JymDyerIBI
left a comment
JymDyerIBI
left a comment
There was a problem hiding this comment.
👍 Whew! A lot of stuff, it looks good.
| lookup("FeedVersion", "publishedVersionId", "namespace", "publishedFeedVersion"), | ||
| unwind("$feedVersions"), | ||
| unwind("$publishedFeedVersion", new UnwindOptions().preserveNullAndEmptyArrays(true)), | ||
| sort(Sorts.descending("feedVersions.dateCreated")), |
Contributor
There was a problem hiding this comment.
If you sort descending, it means the last operator below return the attributes for the earliest version instead of the latest, which result in inconsistent state compared to the "MTC publish" button.
binh-dam-ibigroup
requested changes
Jan 6, 2026
Contributor
binh-dam-ibigroup
left a comment
binh-dam-ibigroup
left a comment
There was a problem hiding this comment.
I found a discrepancy while testing the UI, in some cases the earliest version of a feed is returned instead of the latest.
|
Danke für den Hinweis. |
…ion from latest deployment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
devbefore they can be merged tomaster)Description
Update to provide additional parameters to the UI via feed summary. This now contains two new parameters:
In order to get Gtfs plus validation into feed version, validation now takes places (via ValidateGtfsPlusFeedJob) in the same places as mobility data validation. This only happens with new feed versions and is not backwards compatiable, therefore gtfs plus validation won't be available for older feed versions.