Add fit_predict to FactorizationMachine#38
Conversation
Although required (and now overridden) by mcmc, having this method always present makes it easier to test multiple solvers with minimal code changes
|
I don't like to change the API except for a very good reason, especial if this moves us further away for the sklearn API. I'm not sure if |
|
I am not sure I would say this is changing the API but rather making it consistent. Once |
|
I just revisit this PR once again but still I can't make up my mind if replacing |
Although required (and now overridden) by mcmc, having this method always present makes it easier to test multiple solvers with minimal code changes