Fix: Scope unscale_gradients to relevant optimizers during clipping #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
clip_grad_norm_andclip_grad_value_would unscale gradients for all optimizers managed by the Accelerator, regardless of whether they were associated with the parameters being clipped. This was noted by a TODO comment in the code.This change introduces a
_get_associated_optimizershelper method that identifies which optimizer(s) manage the provided parameters. The clipping functions now use this helper to selectively unscale only the relevant optimizers. If no associated optimizer is found (e.g. for parameters not managed by any optimizer), it falls back to the previous behavior of unscaling all optimizers.This improves efficiency and correctness in setups with multiple optimizers (e.g. GANs, actor-critic) where one might want to clip gradients for one network without affecting the accumulated gradients of another.
Verified with a reproduction script and existing tests.
PR created automatically by Jules for task 2963969511390292436 started by @iavinas