Open
Conversation
BrunnerLivio
commented
Jan 28, 2024
| "extension.generateReactComponentSnippet", | ||
| () => { | ||
| const editor = vscode.window.activeTextEditor; | ||
| if (!editor) { |
Author
There was a problem hiding this comment.
I'd encourage using early returns instead of nesting your code, like you did in the extension.generateReactHookSnippet command.
This leads to much simpler code in my eyes and also decreases the cyclomatic complexity
CodeAesthetics made a video about it if you're curious: https://www.youtube.com/watch?v=CFRhGnuXG-4
|
|
||
| let snippet = ""; | ||
|
|
||
| if (componentType === "fc") { |
Author
There was a problem hiding this comment.
This could be rewritten to use a switch/case instead or even better to use an appropriate data structure so you eliminate any branching code in the first place. But I leave that refactoring to another PR / to you :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related: #3
It's just an initial effort to give a baseline of the described feature :)