Skip to content

Allowing NULL disc.method in the case variables are already discrete #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DouglasMesquita wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allowing NULL disc.method in the case variables are already discrete #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 22 additions & 12 deletions R/prepareTransactions.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,23 +49,33 @@ prepareTransactions <- function(formula, data, disc.method = "mdlp", match = NUL
if(is.logical(data[[i]]))
data[[i]] <- factor(data[[i]], levels = c(TRUE, FALSE))
}
# disc.method is a character string with the method
if(!is.list(disc.method)) {

disc_info <- NULL
data <- discretizeDF.supervised(formula, data, method = disc.method)
disc_info <- lapply(data, attr, "discretized:breaks")
# disc.method is a character string with the method
if(!is.null(disc.method)) {
if(!is.list(disc.method)) {
disc_info <- NULL
data <- discretizeDF.supervised(formula, data, method = disc.method)
disc_info <- lapply(data, attr, "discretized:breaks")

data <- as(data, "transactions")
attr(data, "disc_info") <- disc_info

data <- as(data, "transactions")
attr(data, "disc_info") <- disc_info
return(data)
}

return(data)
}
### disc is a list with discretization info
data <- discretizeDF(
df = data,
methods = lapply(
X = disc.method,
FUN = function(x) list(method = "fixed", breaks = x)
)
)

### disc is a list with discretization info
data <- discretizeDF(data, lapply(disc.method,
FUN = function(x) list(method = "fixed", breaks = x)))
data <- as(data, "transactions")
} else {
data <- as(data, "transactions")
}

return(data)
}
7 changes: 6 additions & 1 deletion tests/testthat/test-discretize.R
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
library("testthat")
library("arulesCBA")


context("Discretization")

data("iris")
Expand All @@ -20,4 +19,10 @@ iris[1:5,1] <- NA
disc <- discretizeDF.supervised(Species ~ ., iris)
disc <- discretizeDF.supervised(Species ~ ., iris, method = "chi2")

iris$disc1 <- cut(iris$Sepal.Length, breaks = 2, include.lowest = TRUE, right = TRUE)
iris$disc2 <- cut(iris$Petal.Length, breaks = 2, include.lowest = TRUE, right = TRUE)

# no disc.method
expect_error(discretizeDF.supervised(Species ~ disc1 + disc2, iris, method = "chi2"))
iris_cat <- iris[c("Species", "disc1", "disc2")]
expect_no_error(prepareTransactions(Species ~ disc1 + disc2, data = iris_cat, disc.method = NULL))