Final project feedback #46
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Ian, Jason, and James,
This looks great! Your code is unbelievably clean and well-organized, on the whole -- a couple comments throughout.
A few general points:
./routes/routes.jsfile? I feel like a bit of reorganization would make the serverside request handling a little easier to understand & maintain... that's a >700 line file.console.logstatements, etc) before you deploy/submit -- particularly because it sounds like you might want to pass this along to future student government teams to maintain/build on, I think you want to set a precedent of code cleanliness. You'll have kind of a tragedy-of-the-commons issue if every future contributor leaves theirconsole.logs in your codebase.Awesome work!
Remember not to merge these pull requests -- take a look at the feedback, feel free to comment if you'd like to discuss anything, and then close the PR.