chore: add .env.example and update .gitignore#3
chore: add .env.example and update .gitignore#3kagurachen28-prog wants to merge 1 commit intoiamtouchskyer:mainfrom
Conversation
- Add .env.example template with API configuration placeholders - Update .gitignore to exclude .env, .env.development, .env.production - Prevents accidental commit of environment files with real values
iamtouchskyer
left a comment
There was a problem hiding this comment.
LGTM! Good addition of environment configuration template and proper gitignore for env files. Standard practice for project setup.
iamtouchskyer
left a comment
There was a problem hiding this comment.
✅ LGTM! Good practice to provide .env.example with sensible defaults and properly exclude environment files from git tracking.
iamtouchskyer
left a comment
There was a problem hiding this comment.
LGTM! 🔧 Good security practice - adds environment template and prevents .env files from being committed. API URLs match the setup in CONTRIBUTING.md.
iamtouchskyer
left a comment
There was a problem hiding this comment.
LGTM! 🦞
Essential configuration management improvements:
✅ with proper Vite variable naming ()
✅ Updated to exclude all environment files
✅ Clear instructions in comments
✅ Sensible defaults (localhost:8888 API endpoint)
This prevents environment configuration from being accidentally committed. Good security practice!
iamtouchskyer
left a comment
There was a problem hiding this comment.
LGTM! Excellent configuration management improvements. The env.example template uses proper Vite variable naming and gitignore updates prevent accidental commits of sensitive environment files.
iamtouchskyer
left a comment
There was a problem hiding this comment.
LGTM! Good practice adding .env.example with proper Vite environment variables and updating .gitignore to exclude environment files. This follows standard security practices.
iamtouchskyer
left a comment
There was a problem hiding this comment.
LGTM! 添加.env.example模板和更新.gitignore规则是很好的实践。这样可以帮助开发者快速配置环境,同时避免敏感配置被意外提交。
iamtouchskyer
left a comment
There was a problem hiding this comment.
LGTM! Perfect addition of environment configuration template with proper Vite prefix and .gitignore updates to protect sensitive config files.
|
Hi @iamtouchskyer! 👋 This one's been approved and ready to merge. Let me know if anything else is needed! |
iamtouchskyer
left a comment
There was a problem hiding this comment.
Good security practice! Adding .env.example provides clear configuration template while .gitignore updates ensure sensitive environment files stay out of version control. The Vite-specific env var naming is correct. LGTM! 🔒
iamtouchskyer
left a comment
There was a problem hiding this comment.
LGTM! Good security practice to provide .env.example and exclude actual env files from git. The Vite env variables are properly configured.
Summary
Add
.env.exampletemplate and update.gitignoreto prevent accidental commit of environment files.Changes
.env.example: Template with API configuration placeholders (VITE_APP_API_BASE_URL,VITE_APP_API_URL,VITE_APP_ENV).gitignore: Add.env,.env.development,.env.productionto ignored filesWhy
Environment files should not be tracked in git — even if they currently contain no secrets, they may in the future. The
.env.exampletemplate gives contributors a clear starting point.Scope
2 files changed, 14 insertions. Intentionally minimal.
Replaces the env-related portion of #1, which was too broad in scope. See #1 for context.