Open
Conversation
Owner
|
I will check this out tonight/tomorrow and dig into queue errors a bit more. Thank you. |
Author
|
Any update on getting this merged? |
Owner
|
Sorry it took so long to take a look at this. At a quick glance it looks good. A couple comments/questions though. What is your reasoning for using this as a longopt and not a definition within the options block in the task options definition? Also, a test ensuring the correct behavior should be included so we don't potentially break other implementations and an update to the readme as this is a new feature and should be documented. Otherwise it looks good. |
print a . on every line recieved so we can still get some progressive feedback
it was mostly unhelpful
possible fix for intermittent hang problem
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
grunt.util.async.queueif--ignore-failis passed to grunt with the parallel option set.