Add FormatManager API to @itwin/quantity-formatting-react #1416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atManager from qty-fmt package
grigasp
reviewed
Aug 21, 2025
Comment on lines
+46
to
+50
| } catch (error) { | ||
| // Query failed, return empty array | ||
| console.warn("Failed to query used KindOfQuantities from iModel:", error); | ||
| return []; | ||
| } |
Member
There was a problem hiding this comment.
Do we really want to hide the error? Generally, we shouldn't do that and instead let components decide what to do with the error - maybe ignore it, maybe show some warning to the user...
Comment on lines
+283
to
+288
| /** | ||
| * Called when an iModel is opened. Sets up schema-based formats if enabled. | ||
| * @param iModel - The opened iModel connection. | ||
| * @param options - Optional configuration for schema format setup. | ||
| */ | ||
| public async onIModelOpen(iModel: IModelConnection, options?: OnIModelOpenOptions): Promise<void> { |
Member
There was a problem hiding this comment.
Who's supposed to call it? The docs give an impression that it should happen automatically, but that doesn't seem to be the case.
| public async onIModelOpen(iModel: IModelConnection, options?: OnIModelOpenOptions): Promise<void> { | ||
| // Set up schema-based units and formats providers | ||
| const schemaFormatsProvider = new SchemaFormatsProvider(iModel.schemaContext, IModelApp.quantityFormatter.activeUnitSystem); | ||
| this.fallbackFormatsProvider = schemaFormatsProvider; |
Member
There was a problem hiding this comment.
Is it by design that FormarManager is compatible with only one iModel at a time?
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite for #1412