Mask precipitation temperature output by precipitation fields #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expand the tests to cover all cases defined in the lookup table.
Marks 2017 specific config variable was read before the model was determined.
The variable was not calculated anywhere.
Improve code style and initialize all variables on class instantiation. Also make sure `precip` is initialized with all zeros.
Reduce the amount of saved data to disk by masking the precipitation temperature identical to the array of precipitation amounts.
jomey
force-pushed
the
precip_temp_mask
branch
from
f59e73b to
a242bfb
Compare
jmichellehu
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mainly to reduce data written to disk.
Also expanded on a few tests for Susong 1999 and expanded the NetCDF verification to check each time slice individually.
Closes #44