Skip to content

MSP: Add minimum power index to MSP_VTX_CONFIG #11190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sensei-hacker wants to merge 1 commit into
base: maintenance-9.x
Choose a base branch
from
+12 −0
Open

MSP: Add minimum power index to MSP_VTX_CONFIG #11190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,3 +46,9 @@ launch.json
# Assitnow token and files for test script
tokens.yaml
*.ubx

# Local development files
.semgrepignore
build_sitl/
CLAUDE.md
brother/
6 changes: 6 additions & 0 deletions src/main/fc/fc_msp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1526,6 +1526,12 @@ static bool mspFcProcessOutCommand(uint16_t cmdMSP, sbuf_t *dst, mspPostProcessF
sbufWriteU8(dst, vtxDevice->capability.bandCount);
sbufWriteU8(dst, vtxDevice->capability.channelCount);
sbufWriteU8(dst, vtxDevice->capability.powerCount);

uint8_t minPowerIndex = 1;
if (deviceType == VTXDEV_MSP) {
minPowerIndex = 0;
}
sbufWriteU8(dst, minPowerIndex);
Comment on lines 1528 to +1534
Copy link
Contributor

@qodo-code-review qodo-code-review bot Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Adding a new byte to the MSP reply increases the payload size; ensure the destination buffer has room (or update the reply-size calculation) before writing to avoid overruns. [Learned best practice, importance: 6]

Suggested change
sbufWriteU8(dst, vtxDevice->capability.powerCount);
uint8_t minPowerIndex = 1;
if (deviceType == VTXDEV_MSP) {
minPowerIndex = 0;
}
sbufWriteU8(dst, minPowerIndex);
sbufWriteU8(dst, vtxDevice->capability.powerCount);
const uint8_t minPowerIndex = (deviceType == VTXDEV_MSP) ? 0 : 1;
if (sbufBytesRemaining(dst) < 1) {
return false;
}
sbufWriteU8(dst, minPowerIndex);

}
else {
sbufWriteU8(dst, VTXDEV_UNKNOWN); // no VTX configured
Expand Down