Skip to content

Use penthouse fork #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
batbattur merged 2 commits into from
May 12, 2023
Merged

Use penthouse fork #12

batbattur merged 2 commits into from
May 12, 2023

Conversation

@batbattur
Copy link
Contributor

@batbattur batbattur commented May 12, 2023

Summary

Background #11.

Let's use our penthouse fork with an updated puppeteer version, ref: iFixit/penthouse#1.

This will resolve some issues we were seeing with :where selectors.

QA notes

Repeat the steps from #11 (comment).

@batbattur batbattur added the QAE Quality Assurance Engineering label May 12, 2023
@batbattur batbattur self-assigned this May 12, 2023
@batbattur batbattur added the QAing Under QA team review label May 12, 2023
mlahargou
mlahargou approved these changes May 12, 2023
View reviewed changes
Copy link
Member

@mlahargou mlahargou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR 📱 Cool! If we make any other changes to our penthouse, they will get automatically picked up. I think that's fine.

@batbattur
Copy link
Contributor Author

batbattur commented May 12, 2023

Steps used to test:

  1. Created a test branch to run the critical-css.yml from this branch: https://github.com/iFixit/ifixit/compare/testing-css-gather-forked-penthouse
  2. Ran gh workflow run critical-css.yml --ref=testing-css-gather-forked-penthouse from cominor. Then it created https://github.com/iFixit/ifixit/actions/runs/4961471385 run.
  3. Finally, it created a pull request with the changes from this pull: https://github.com/iFixit/ifixit/pull/47875/files
  4. Made sure the :where(...) selectors are included in the generated critical-css files.

QA 🚀

@batbattur batbattur removed the QAing Under QA team review label May 12, 2023
@batbattur batbattur merged commit 799c796 into main May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mlahargou mlahargou mlahargou approved these changes

Assignees

@batbattur batbattur

Labels

QAE Quality Assurance Engineering

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@batbattur @mlahargou