fix online refund (creditmemo)

[simonrl]

Hi,

please merge this PR, it fixes the code in version 1.3.6.

if (!$transactions = [...] doesn't help much when the condition is throwing an exception.

Thanks
Simon

[markusbehrens]

guys, when are you planning on merging this PR? we had 404 errors in one of our shops using 1.3.5 and I tested if updating to 1.3.6 would help. well, it might help on some orders but now throws 404s on others. like @simonrl wrote, you cannot just check for !transaction, because $this->getPayment($paymentId)->getTransactions() throws an exception in your general direction when it does not like $paymentId. so we need to use try / catch instead. I really hope there's a new release coming out soon which fixes this issue. are there any infos on when this is to be expected?

[simonrl]

@markusbehrens

You can contact their support here: https://support.i-ways.net/hc/de, but tbh, don't expect too much.

In the meantime, you should be able to grab my commit using https://github.com/cweagans/composer-patches using this URL: https://github.com/i-ways/magento2-paypal-plus/commit/3823c89c10318013cc4a849b2f6efdf0a7b7fd71.patch

[markusbehrens]

@simonrl
thanks for the patch link! I have some experience with i-ways support and it's been a mixed bag. But I wrote them a message describing the issue and asking for a possible release date for a fix.
Meanwhile we will probably use your fix, until they release a new version officially.