-
Notifications
You must be signed in to change notification settings - Fork 103
Upload files about CS274A KuangPenghao #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: file-base
Are you sure you want to change the base?
Conversation
Upload final review note, cheatsheet
Added README file explaining the cheatsheet formats.
|
Hi! Thank you very much for your contribution! I'll review this PR after merging the previous ones. Sorry but it may take some time. |
why-in-Shanghaitech
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, only some minor issues before I can merge this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There has already been a folder called 'Cheatsheet 速查清单', could you please change your folder name such that the content could merge?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it mean I should change my folder name to "Cheatsheet 速查清单"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, now it is fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's not necessary to keep the readme file because visitors only want a cheatsheet. I think a simple .md or .pdf file is enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, so maybe I can remove all .md and only keep .pdf and .docx, and do not need to fix the issue of the markdown below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like method above, maybe I can remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider rename the files since there are cheatsheets from more than one student.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to the above (folder name, render issues, readme file)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'_' is not necessary for the folder name
|
Fixed. Continue to retain markdown and solve the issues. |
Added tutorial video pages for Weeks 1 to 13 with embedded video links.
|
Add source of tutorials of MATH1112 (Linear Algebra) 25 Fall, all the tutorials of this semester have completed. Including all lecture notes and lecture videos. Moreover, I've seen the announcement of student needed for maintaining iTechX. However, maybe few students will notice this announcement through website because they tend to ignore announcements and only focus on searching and upload materials. Maybe I can advitise in groups of grade 2023 2024 2025, finding students who want to take over the work. |
why-in-Shanghaitech
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think everything is fine except that MATH1112 cannot render. Once this is fixed I think this PR is ready to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MATH1112 cannot render. I think this is because it lacks the metadata (meta.json, cover.jpg). Could you fix that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I will be extremely busy during the coming 3 weeks (so sorry), I consider to fix it in winter holiday. Moreover, does it need name of instructors and TAs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. If you don't know, add an "unknown" string is enough. If you need help please leave a note.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The instructor of this course this semester is 董俊斌, and there are 3 TAs in his class: 匡鹏昊、李岷璨、唐煜杰
Thank you so much! Please feel free to spread the message. I think one or two students passionate on iTechX is enough. |
|
Update meta.json,add instructor 董俊斌 and TA 匡鹏昊 at the end of the json file. |

Containing 3 file folders:Cheatsheet, Final Review Notes and Handwriting Notes.