fix (crit): include backup_moves check in getMoveDetails() to force crit toggle UI active#5
Open
ghostyboyy97 wants to merge 1 commit intohzla:decompfrom
Open
fix (crit): include backup_moves check in getMoveDetails() to force crit toggle UI active#5ghostyboyy97 wants to merge 1 commit intohzla:decompfrom
ghostyboyy97 wants to merge 1 commit intohzla:decompfrom
Conversation
…rit toggle UI active
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emerald Imperium - Inteleon w/ Snipe Shot (+2 crit stage) and Scope Lens (+1 crit stage = guaranteed crit) was showing crit damage correctly, but the crit toggle in the move UI was not set to active like for other guaranteed crit moves. There might be a better place in the calc process to force the toggle on for cases like this, but this should help catch any cases like that.