Skip to content

Upload build artefacts on CI #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hzeller merged 3 commits into from
Aug 7, 2025
Merged

Upload build artefacts on CI #11

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1fe9333
Update ci.yml
alvinometric Aug 7, 2025
824e7e0
fix conflicting artefacts, restore comment
alvinometric Aug 7, 2025
25f7f48
Newer Ubuntu
alvinometric Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,38 +4,42 @@ on:
branches:
- master
pull_request:

jobs:
BuildLinux:
runs-on: ubuntu-20.04 # test slightly older ubuntu.
runs-on: ubuntu-24.04
Copy link
Owner

@hzeller hzeller Aug 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of 24, i'd still use 22, because I would like to make sure that things still compile on older systems.

Can you figure out the necessary flags we can give to the makefile in linking so that we can have a fully statically linked binary ?

Copy link
Contributor Author

@alvinometric alvinometric Aug 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up to you but we're 6 months away from 24.04 becoming the older system ?

Copy link
Owner

@hzeller hzeller Aug 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair enough.

strategy:
fail-fast: false
matrix:
compiler:
- g++
- clang++

name: Build ${{matrix.compiler}}
steps:
- name: Get the Source
uses: actions/checkout@v3

uses: actions/checkout@v4
- name: Configure shell
run: |
echo "CXX=${{ matrix.compiler }}" >> $GITHUB_ENV
echo "CXXFLAGS=-Werror" >> $GITHUB_ENV

- name: Build
run: |
make -k

- name: Upload build artifacts
uses: actions/upload-artifact@v4
with:
name: gcode-cli-linux-${{ matrix.compiler }}
path: gcode-cli
BuildMac:
name: Build Mac
runs-on: macos-latest
steps:
- name: Get the Source
uses: actions/checkout@v3

uses: actions/checkout@v4
- name: Build
run: |
make -k
- name: Upload build artifacts
uses: actions/upload-artifact@v4
with:
name: gcode-cli-mac
path: gcode-cli
Loading