refactor: Migrate from SharedPreferences to DataStore#3
Open
941kjw wants to merge 4 commits intohyunnnchoi:mainfrom
Open
refactor: Migrate from SharedPreferences to DataStore#3941kjw wants to merge 4 commits intohyunnnchoi:mainfrom
941kjw wants to merge 4 commits intohyunnnchoi:mainfrom
Conversation
KeyStore-backed value encryption for DataStore
Replace EncryptedSharedPreferences with DataStore Preferences. Sensitive values encrypted via ValueEncryption; in-memory cache for hasCredential/getRefreshInterval/isNotificationsEnabled.
SettingsViewModel: launch for load/save/settings; QuotaRefreshWorker: make checkForResets suspend for loadResetTimes/saveResetTimes.
Drop EncryptedSharedPreferences dependency. Stub suspend loadCredential in tests with runBlocking; update README security line.
941kjw
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate from SharedPreferences to DataStore
Summary
Replaces
EncryptedSharedPreferenceswith DataStore Preferences plus value-level encryption (Android KeyStore AES-256-GCM), aligning with current Android recommendations and improving async safety.What changed
ValueEncryptionhelper backed by Android KeyStore.hasCredential,getRefreshInterval,isNotificationsEnabledremain sync and are backed by an in-memory cache.androidx.security:security-crypto(EncryptedSharedPreferences).Checklist
How to test
./gradlew testDebugUnitTest --tests "com.codexbar.android.core.data.*"Related
Notes
codexbar_datastore_aes_key), generated on first use; no hardcoded secrets.codexbar_secure_prefs; format differs from old prefs, so no automatic migration.