HC-314: Added paginate flag to enable pagination #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DustinKLo
approved these changes
Jan 25, 2021
Contributor
DustinKLo
left a comment
DustinKLo
left a comment
There was a problem hiding this comment.
LGTM 👍
because HySDS v3 is legacy we'll keep backwards compatibility but v4 will disable the "fetch all" capabilities in get_job_list
...also because hysds_commons.request_utils was removed in v4 so we don't get things like get_scrolled_json_response for free anymore
pymonger
reviewed
Feb 1, 2021
|
|
||
|
|
||
| def post_scrolled_json_responses(url, es_url, generator=False, **kwargs): | ||
| def post_scrolled_json_responses(url, es_url, paginate=False, generator=False, **kwargs): |
Contributor
There was a problem hiding this comment.
Suggested change
| def post_scrolled_json_responses(url, es_url, paginate=False, generator=False, **kwargs): | |
| def post_scrolled_json_responses(url, es_url, generator=False, paginate=False, **kwargs): |
@NamrataM: thinking that we should move paginate after the generator kwarg since generator existed before the addition of paginate and end users may be calling the method without specifying generator=<var>.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enable pagination, I've introduced a flag called
paginateto control limiting of result size. Ifpaginateis set toTrueresults should be limited by page size and offset. They would be specified in the url inputted to the function. IfpaginateisFalseor is not specified, the function will scan, collect and return all records for the query.