Skip to content

Conversation

@pymonger
Copy link
Contributor

@pymonger pymonger commented Dec 19, 2025

Without this pin, code that imports the celeryconfig.py that's copied to the hysds repo directory, e.g.:

  • ~/mozart/ops/hysds
  • ~/verdi/ops/hysds
  • ~/sciflo/ops/hysds
  • ~/metrics/ops/hysds

will fail to find celeryconfig.py. This pin is a temporary hotfix until we can formally address this in HC-604 (https://hysds-core.atlassian.net/browse/HC-604).


Note

Pins pip to <25.2 (and continues setuptools <80) in install.sh to maintain compatibility with legacy setup.py develop editable installs.

  • Install script (install.sh):
    • Pin pip to <25.2 to preserve compatibility with legacy setup.py develop editable installs (removed in pip 25.3).
    • Continue pinning setuptools to <80.0.0.
    • Add brief in-script documentation explaining the pin rationale.

Written by Cursor Bugbot for commit f62cd41. This will update automatically on new commits. Configure here.

@pymonger pymonger requested a review from mcayanan December 19, 2025 21:27
Copy link
Contributor

@mcayanan mcayanan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good. Ya I agree that we need a more formal way to resolve this.

v6.0.3 already has pip 25.3 installed in it and what SWOT did to address that were the following updates:

Just making sure, this PR will be backwards compatible to the changes that SWOT already made to address this? Meaning I can just leave these swot updates as-is and still take in this change once it's merged into develop?

@pymonger
Copy link
Contributor Author

This is good. Ya I agree that we need a more formal way to resolve this.

v6.0.3 already has pip 25.3 installed in it and what SWOT did to address that were the following updates:

* https://github.jpl.nasa.gov/IEMS-SDS/swot-pcm/pull/904

* https://github.jpl.nasa.gov/IEMS-SDS/swot-pcm/pull/895

Just making sure, this PR will be backwards compatible to the changes that SWOT already made to address this? Meaning I can just leave these swot updates as-is and still take in this change once it's merged into develop?

@mcayanan: @sujen1412 makes a good point that we should move away from editable installations so what you did in SWOT should be done in NISAR as well. We can hold off on this PR until we get back from the holidays to sort that out for NISAR.

@pymonger
Copy link
Contributor Author

pymonger commented Jan 5, 2026

Closed in favor of updating adaptation to include the path to the celeryconfig.py to PYTHONPATH.

@pymonger pymonger closed this Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants