image: pass size to CImage for SVG rendering #949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SVG images require a target size to be rendered, but hyprlock was creating CImage without passing the size parameter. This caused hyprgraphics to fail with "loading svg: invalid size" error. This fix passes the image widget's configured size through the preload request props to getCairoSurfaceFromImageFile(), which then uses the two-argument CImage constructor for SVG files. Fixes hyprwm#940
Member
|
looks like it needs a rebase? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SVG images failed to load with the error "loading svg: invalid size" because hyprlock was not passing the configured size to hyprgraphics'
CImageconstructor.Unlike raster formats, SVG requires a target render size since it's vector-based. The
CImageclass has a two-argument constructorCImage(path, size)for this, butgetCairoSurfaceFromImageFile()was only using the single-argument constructor, resulting in a 0x0 render target.This fix passes the image widget's configured
sizeparameter through the preload request props torenderImage(), which then forwards it togetCairoSurfaceFromImageFile().Caveats
This PR probably should not be merged for the following reasons:
sizeoption is not well-suited for SVG rendering - SVGs are rendered as square (size × size), ignoring intrinsic aspect ratiowidth/heightoptions and querying intrinsic SVG dimensions from librsvgSubmitting this as a reference for the issue and as a potential stopgap if needed.
Fixes #940