Improve tests in the freenet.clients package
#828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wait for all threads to start and pause on the CountDownLatch. Then send start signal to all threads and call the method under test. This makes invocation more concurrent and forces all threads to start at the same place. Signed-off-by: Veniamin Fernandes <veniamin.fernandes@proton.me>
Adds improvements to assertions and code formatting Signed-off-by: Veniamin Fernandes <veniamin.fernandes@proton.me>
Remove commented and broken parsing. Add date and time parsing, which can parse various timestamps defined in multiple HTTP standards. Main algorithm is defined in https://www.ietf.org/rfc/rfc6265.html#section-5.1.1 Also use newer classes from java.time package. Signed-off-by: Veniamin Fernandes <veniamin.fernandes@proton.me>
Improved unit tests for Cookie And ReceivedCookie classes. Split ReceivedCookie class out of Cookie class, and removed unused parts. Set-Cookie2 and Cookie2 format is no longer used in modern browsers. Newer specification RFC6225 defines received cookie as key value pairs only. ReceivedCookie uses only cookie name and value, and others parts were not used and are removed now. Signed-off-by: Veniamin Fernandes <veniamin.fernandes@proton.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve tests in the
freenet.clientspackageDepends on:
freenet.clientpackage #826freenet.clientspackage.TimeUtilCookieandReceivedCookieclasses.