Announcement fixes cherry picked from pr 746 #780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BEWARE. TOTALLY UNTESTED CODE PATH ENABLED. This code never worked correctly since introduction in commit f32e365 (svn r16190).
… bug fix, not the cleanup ] and we got off with that only because shouldAcceptAnnounce was broken too.
…ounce was completely broken", not including the stuff about double announcement (which isn't relevant).
…es. Don't assert. Not the same as Eleriseth's patch, but thanks Eleriseth for pointing out the issue.
vwoodzell
reviewed
Oct 2, 2022
Contributor
vwoodzell
left a comment
vwoodzell
left a comment
There was a problem hiding this comment.
The new logic seems to be correct. Nice to enable a feature that's never worked. :) I can't comment on the effect that the feature might have.
Contributor
Author
|
Thank you for checking! We might have to roll this out on one or two seednodes first to check whether it throttles announcements too much. I’ve seen a seednode have all peers in backoff, so this could be important to have (and an overall improvement). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes that look like they should be included even if we do not merge PR #746 , but they need more review.