Skip to content

Conversation

@michaelfig
Copy link
Contributor

@michaelfig michaelfig commented May 28, 2025

This PR removes support for the broken inputs.name support, and also removes the CI with.name usage that caused starship stop to attempt deleting a different Helm release name than the one specified in the starship-action's config file.

This will allow starship stop to successfully delete the Helm release. Before, it failed and waited until the Actions job timeout elapses (currently 6h, but also updated in this PR to be just 15 minutes):

Run starship stop --config config.yaml --namespace $NAMESPACE || true
  starship stop --config config.yaml --namespace $NAMESPACE || true
  kubectl delete namespace $NAMESPACE --wait=true
  shell: /usr/bin/bash -e {0}
  env:
    NAMESPACE: ci-hyperweb-io-starship-action-test-refs-heads-main
argv: config : config.yaml
argv: namespace : ci-hyperweb-io-starship-action-test-refs-heads-main
config again: [object Object]
Trying to stop all port-forward, if any....
helm delete osmo-wasm --namespace ci-hyperweb-io-starship-action-test-refs-heads-main
Error: uninstall: Release not loaded: osmo-wasm: release: not found
[osmosis-1-genesis-0]: Terminating, Ready: true, Restarts: 1
[wasmd-genesis-0]: Terminating, Ready: true, Restarts: 0
[osmosis-1-genesis-0]: Terminating, Ready: true, Restarts: 1
...

@michaelfig michaelfig changed the title Mfig ci stop ci: use the correct --name to clean up each Helm release May 28, 2025
The `test.yaml` workflow was using `inputs.name`, but it only
worked because the `name` input was not defined in the
`starship-action`.

When `inputs.name` support was implemented in PR hyperweb-io#42, it broke
the `test.yaml` workflow because the `starship stop --name`
setting overrode the `config.yml` `name:` value.  This
installed the Helm release with a different name than what was
being stopped.

Without stopping the correct Helm release, `starship stop`
would hang indefinitely.  Now it doesn't.
@michaelfig michaelfig changed the title ci: use the correct --name to clean up each Helm release ci: remove broken --name ${input.name} support May 28, 2025
@michaelfig michaelfig changed the title ci: remove broken --name ${input.name} support ci: remove broken --name ${inputs.name} support May 28, 2025
@Anmol1696 Anmol1696 merged commit d854f77 into hyperweb-io:main May 29, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants