Skip to content

feat: hyperapp returns any Rust type, not just Result #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jurij-jukic merged 1 commit into from
Oct 30, 2025
Merged

feat: hyperapp returns any Rust type, not just Result #391

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions src/build/caller_utils_ts_generator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -706,7 +706,7 @@ fn generate_typescript_function(
)
};

// Function returns the unwrapped type since parseResultResponse extracts it
// Function returns the unwrapped type since parseResponse extracts it
let function_impl = format!(
"/**\n * {}\n{} * @returns Promise with result\n * @throws ApiError if the request fails\n */\nexport async function {}({}): Promise<{}> {{\n{}\n\n return await apiRequest<{}, {}>('{}', 'POST', data);\n}}",
camel_function_name,
Expand Down Expand Up @@ -789,16 +789,20 @@ pub fn create_typescript_caller_utils(base_dir: &Path, api_dir: &Path) -> Result

ts_content.push_str("// Parser for the Result-style responses\n");
ts_content.push_str("// eslint-disable-next-line @typescript-eslint/no-explicit-any\n");
ts_content.push_str("export function parseResultResponse<T>(response: any): T {\n");
ts_content.push_str("export function parseResponse<T>(response: any): T {\n");
ts_content.push_str(" try {\n");
ts_content.push_str(
" if ('Ok' in response && response.Ok !== undefined && response.Ok !== null) {\n",
" if ('Ok' in response && response.Ok !== undefined && response.Ok !== null) {\n",
);
ts_content.push_str(" return response.Ok as T;\n");
ts_content.push_str(" }\n\n");
ts_content.push_str(" if ('Err' in response && response.Err !== undefined) {\n");
ts_content.push_str(" throw new ApiError(`API returned an error`, response.Err);\n");
ts_content.push_str(" }\n\n");
ts_content.push_str(" throw new ApiError('Invalid API response format');\n");
ts_content.push_str(" return response.Ok as T;\n");
ts_content.push_str(" }\n\n");
ts_content.push_str(" if ('Err' in response && response.Err !== undefined) {\n");
ts_content.push_str(" throw new ApiError(`API returned an error`, response.Err);\n");
ts_content.push_str(" }\n");
ts_content.push_str(" } catch (e) {\n");
ts_content.push_str(" return response as T;\n");
ts_content.push_str(" }\n");
ts_content.push_str(" return response as T;\n");
ts_content.push_str("}\n\n");

ts_content.push_str("/**\n");
Expand Down Expand Up @@ -828,7 +832,7 @@ pub fn create_typescript_caller_utils(base_dir: &Path, api_dir: &Path) -> Result
.push_str(" throw new ApiError(`HTTP request failed with status: ${result.status}`);\n");
ts_content.push_str(" }\n\n");
ts_content.push_str(" const jsonResponse = await result.json();\n");
ts_content.push_str(" return parseResultResponse<R>(jsonResponse);\n");
ts_content.push_str(" return parseResponse<R>(jsonResponse);\n");
ts_content.push_str("}\n\n");

// Collect types grouped by hyperapp
Expand Down