fix: color coding of errors #381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
there seems to be some strange nondeterministic behavior with kit, i cant fully track this down yet |
jurij-jukic
force-pushed
the
j/error-color-codes
branch
from
fa5c4cc to
943b002
Compare
Contributor
Author
|
oh shit, it works for u, lfg! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eyre implements Debug which shows the ANSI escape codes. we need to use Display in order for the error to show actual colors. CommandExecutionError implements display and formats stderr and stdout nicely. I hope the custom type is okay, I didn't really find another way, except flushing the stdout and stderr directly into the terminal rather than being returned through Err.