Skip to content

improve backwards compat #912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nick1udwig merged 2 commits into from
Dec 26, 2025
Merged

improve backwards compat #912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
948f28c
attempt to improve backwards compat
nick1udwig Dec 26, 2025
91392a9
Merge branch 'develop' into hf/improve-backwards-compat
nick1udwig Dec 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions hyperdrive/packages/app-store/downloads/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ type ManualDownloads = HashMap<(PackageId, String), ManualDownloadStatus>;
#[derive(Debug, Serialize, Deserialize)]
pub struct State {
// persisted metadata about which packages we are mirroring
#[serde(default)]
mirroring: HashSet<PackageId>,
// note, pending auto_updates are not persisted.
}
Expand Down
6 changes: 6 additions & 0 deletions hyperdrive/packages/hypermap-cacher/binding-cacher/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,10 @@ const DEFAULT_NODES: &[&str] = &[
#[cfg(feature = "simulation-mode")]
const DEFAULT_NODES: &[&str] = &["fake.os"];

fn default_nodes() -> Vec<String> {
DEFAULT_NODES.iter().map(|s| s.to_string()).collect()
}

// Internal representation of LogsMetadata, similar to WIT but for Rust logic.
#[derive(Serialize, Deserialize, Debug, Clone)]
struct LogsMetadataInternal {
Expand Down Expand Up @@ -105,7 +109,9 @@ struct State {
block_batch_size: u64,
is_cache_timer_live: bool,
drive_path: String,
#[serde(default)]
is_providing: bool,
#[serde(default = "default_nodes")]
nodes: Vec<String>,
#[serde(skip)]
is_starting: bool,
Expand Down
6 changes: 6 additions & 0 deletions hyperdrive/packages/hypermap-cacher/hypermap-cacher/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,10 @@ const DEFAULT_NODES: &[&str] = &[
#[cfg(feature = "simulation-mode")]
const DEFAULT_NODES: &[&str] = &["fake.os"];

fn default_nodes() -> Vec<String> {
DEFAULT_NODES.iter().map(|s| s.to_string()).collect()
}

// Internal representation of LogsMetadata, similar to WIT but for Rust logic.
#[derive(Serialize, Deserialize, Debug, Clone)]
struct LogsMetadataInternal {
Expand Down Expand Up @@ -102,7 +106,9 @@ struct State {
block_batch_size: u64,
is_cache_timer_live: bool,
drive_path: String,
#[serde(default)]
is_providing: bool,
#[serde(default = "default_nodes")]
nodes: Vec<String>,
#[serde(skip)]
is_starting: bool,
Expand Down