kns & app_store: store logs in state #614
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
dr-frmr
reviewed
Dec 2, 2024
| #[cfg(feature = "simulation-mode")] | ||
| add_temp_hardcoded_tlzs(&mut state); | ||
|
|
||
| let contract_address = KIMAP_ADDRESS.parse::<eth::Address>().unwrap(); |
Contributor
There was a problem hiding this comment.
There is a reason contract address was a field inside state. If the contract address changes, state must be reset. This was particularly an issue in beta as contract address could change -- extremely unlikely to happen on mainnet, but should still keep it in state especially now that we can perform state migrations in this app.
| // 60s timeout -- these calls can take a long time | ||
| // if they do time out, we try them again | ||
| let eth_provider: eth::Provider = eth::Provider::new(state.chain_id, SUBSCRIPTION_TIMEOUT); | ||
| let eth_provider: eth::Provider = eth::Provider::new(CHAIN_ID, SUBSCRIPTION_TIMEOUT); |
Contributor
There was a problem hiding this comment.
Chain ID should also be in state so it can migrate smoothly
Contributor
There was a problem hiding this comment.
Imagine a future where kns_indexer reads from multiple chains. Not too far away
Contributor
Author
|
superceded and addressed by #620 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Re-indexing of both app_store and kns kimap logs is becoming bulky enough to soon warrant better indexing.
Solution
Save old verified logs in state, looking for new ones.
Also, save state in extendable versioned enum way, so we can easily add/migrate in backwards compatible ways.
Notes