feat: Migrate developer hovercard info to Gitee #970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangyantong2000
requested changes
Mar 1, 2025
| return null; | ||
| }; | ||
|
|
||
| const waitForValidPopover = async (signal: AbortSignal): Promise<HTMLElement | null> => { |
Collaborator
There was a problem hiding this comment.
Why is the signal parameter set when it is not used
Collaborator
This feature needs to be reviewed and done again.
|
Collaborator
Author
|
Fixed the timer issue and removed unnecessary parameters. @wangyantong2000 |
Collaborator
Only the homepage is in effect, other scenarios have not been considered yet |
Collaborator
Author
|
@wangyantong2000 Please review again |
| // if (existingPopover) { | ||
| // resolve(existingPopover as HTMLElement); | ||
| // return; | ||
| // } |
Collaborator
There was a problem hiding this comment.
If you're sure you don't need it here, you can delete it. Once ready, you can convert the draft PR to a formal PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of (more info about types):
Related issues (all available keywords):
Details
Checklist
Others