Closed
Conversation
… version requirements
…indows environments
… exception handling in stage_test
…iple Python versions
…nd process wrapper
…w for Windows compatibility
…on and improve error handling
- Remove --exit-zero flag to make CI fail when linting issues are found - Remove redundant ruff format command as formatting is handled by --fix flag
- Replace verbose include-based matrix with compact array syntax - Keep the same test coverage (3 OS x 3 Python versions) - Test environments remain unchanged: - OS: ubuntu-latest, windows-latest, macos-14 - Python: 3.10, 3.11, 3.12
- Create get-python-version reusable action - Use it in lint and mypy jobs - Keep matrix-based versions for test and build jobs - Remove unnecessary fallback version - Reduce code duplication
- Simplify poetry version reading in prepare action - Add direct Python version reading from .python-version file - Standardize version reading across workflows - Use consistent python_version variable naming - Remove redundant else clause in poetry version check
- Ignore type annotation rules (ANN*) as they require significant codebase changes - Ignore path manipulation rules (PTH*) as they are project-specific - Ignore security rules (S*) that are not applicable - Ignore other style rules that are too strict for current codebase - Keep ERA001 (commented-out-code) enabled as it can be auto-fixed
- Ignore type annotation rules (ANN*) as they require significant codebase changes - Ignore path manipulation rules (PTH*) as they are project-specific - Ignore security rules (S*) that are not applicable - Ignore other style rules that are too strict for current codebase - Keep ERA001 (commented-out-code) enabled as it can be auto-fixed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task: #HSPC-
Reviewers
Description