This repository was archived by the owner on Sep 5, 2025. It is now read-only.
Add cleanup func for returning dgo client to pool#93
Merged
matthewmcneely merged 1 commit intomainfrom May 7, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the DgraphClient function to return a cleanup function along with the client, enabling proper resource management for remote cluster clients.
- In query_test.go, the test is updated to receive and defer the cleanup function.
- In client.go, the DgraphClient method is refactored to provide a cleanup function that returns the client to the pool.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| query_test.go | Updated to use the new DgraphClient signature and defer the cleanup call. |
| client.go | Modified DgraphClient to return a cleanup function along with the client. |
ryanfoxtyler
approved these changes
May 7, 2025
matthewmcneely
deleted the
matthewmcneely/add-cleanup-func-for-dgraph-client
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a cleanup func to the return signature of client.DgraphClient. Needed to properly return the dgo client to the pool. This doesn't effect file-based instances, just those that work with remote clusters.
Checklist