This repository was archived by the owner on Sep 5, 2025. It is now read-only.
chore: add load example amd query CLI#91
Merged
matthewmcneely merged 7 commits intomainfrom May 1, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces two new command-line tools—a loader for the 1million dataset and a query CLI—while updating existing logging calls to use the configured logger.
- Introduces a new load example CLI in the examples/load folder.
- Adds a query CLI in the cmd/query folder along with associated documentation.
- Updates logging calls in live_test.go, live.go, and client.go to consistently use the logger.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| load_test/live_test.go | Updates logging to use stdr logger for engine configuration. |
| live.go | Replaces standard logging with engine.logger for consistency. |
| examples/load/main.go | New loader CLI with download and progress tracking logic. |
| examples/load/README.md | Documentation for the new load CLI tool. |
| examples/basic/main.go | Adjusted verbosity flag parsing logic. |
| cmd/query/main.go | New query CLI implementation for executing DQL queries. |
| cmd/query/README.md | Documentation for the query CLI tool. |
| client.go | Modified QueryRaw to leverage engine namespace queries. |
| README.md | Updated CLI commands and example usage details. |
Comments suppressed due to low confidence (1)
live.go:84
- [nitpick] Consider logging the 'rate' value as a numeric type rather than formatting it as a string using fmt.Sprintf, if the logger supports numeric values. This may enable better downstream processing and filtering of log data.
n.engine.logger.Info("Data loading progress", "elapsed", x.FixedDuration(elapsed), "quads", nqudsProcessed, "rate", fmt.Sprintf("%5.0f", rate))
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
ryanfoxtyler
approved these changes
May 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a load example and a query cli
Checklist