This repository was archived by the owner on Sep 5, 2025. It is now read-only.
feat: update modusDB interface to driver and db#41
Closed
mangalaman93 wants to merge 10 commits intomainfrom
Closed
feat: update modusDB interface to driver and db#41mangalaman93 wants to merge 10 commits intomainfrom
mangalaman93 wants to merge 10 commits intomainfrom
Conversation
jairad26
reviewed
Jan 10, 2025
… logical separation
jairad26
changed the title
jairad26
previously approved these changes
Jan 10, 2025
mangalaman93
commented
Jan 15, 2025
Contributor
Author
mangalaman93
left a comment
mangalaman93
left a comment
There was a problem hiding this comment.
two minor comments. LGTM otherwise.
jairad26
approved these changes
Jan 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the nomenclature from db and namespace to engine and namespace to better represent common DB terminology
it also removes the notion of opertaion on both the entities, all mutations, queries, and drop datas are conducted on namespaces. the engine is responsibile for drop all & maintaining namespaces & state