Skip to content

fix: correct HDKey seed error message to report 64 bytes instead of 32 #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yshyn-iohk merged 1 commit into from
Mar 5, 2026
+7 −6
Merged

fix: correct HDKey seed error message to report 64 bytes instead of 32 #219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apollo/src/androidMain/kotlin/org/hyperledger/identus/apollo/derivation/EdHDKey.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ actual class EdHDKey actual constructor(
*/
actual fun initFromSeed(seed: ByteArray): EdHDKey {
require(seed.size == 64) {
"Seed expected byte length to be ${ECConfig.PRIVATE_KEY_BYTE_SIZE}"
"Seed expected byte length to be ${ECConfig.SEED_BYTE_SIZE}"
}

val keySlice = seed.sliceArray(0 until 32)
Expand Down
2 changes: 1 addition & 1 deletion apollo/src/appleMain/kotlin/org/hyperledger/identus/apollo/derivation/EdHDKey.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ actual class EdHDKey actual constructor(
*/
actual fun initFromSeed(seed: ByteArray): EdHDKey {
require(seed.size == 64) {
"Seed expected byte length to be ${ECConfig.PRIVATE_KEY_BYTE_SIZE}"
"Seed expected byte length to be ${ECConfig.SEED_BYTE_SIZE}"
}

val keySlice = seed.sliceArray(0 until 32)
Expand Down
4 changes: 2 additions & 2 deletions apollo/src/commonMain/kotlin/org/hyperledger/identus/apollo/derivation/HDKey.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ class HDKey(
childIndex = childIndex
) {
require(seed.size == 64) {
"Seed expected byte length to be ${ECConfig.PRIVATE_KEY_BYTE_SIZE}"
"Seed expected byte length to be ${ECConfig.SEED_BYTE_SIZE}"
}
}

Expand All @@ -127,7 +127,7 @@ class HDKey(
childIndex = BigIntegerWrapper(childIndex)
) {
require(seed.size == 64) {
"Seed expected byte length to be ${ECConfig.PRIVATE_KEY_BYTE_SIZE}"
"Seed expected byte length to be ${ECConfig.SEED_BYTE_SIZE}"
}
}

Expand Down
1 change: 1 addition & 0 deletions apollo/src/commonMain/kotlin/org/hyperledger/identus/apollo/utils/ECConfig.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import kotlin.js.JsExport
@JsExport
object ECConfig {
val PRIVATE_KEY_BYTE_SIZE: Int = 32
val SEED_BYTE_SIZE: Int = 64
internal val PUBLIC_KEY_COORDINATE_BYTE_SIZE: Int = 32
internal val PUBLIC_KEY_COMPRESSED_BYTE_SIZE: Int = PUBLIC_KEY_COORDINATE_BYTE_SIZE + 1
val SIGNATURE_MAX_BYTE_SIZE: Int = 72
Expand Down
2 changes: 1 addition & 1 deletion apollo/src/jsMain/kotlin/org/hyperledger/identus/apollo/derivation/EdHDKey.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ actual class EdHDKey actual constructor(
*/
actual fun initFromSeed(seed: ByteArray): EdHDKey {
require(seed.size == 64) {
"Seed expected byte length to be ${ECConfig.PRIVATE_KEY_BYTE_SIZE}"
"Seed expected byte length to be ${ECConfig.SEED_BYTE_SIZE}"
}

val key = seed.sliceArray(0 until 32)
Expand Down
2 changes: 1 addition & 1 deletion apollo/src/jvmMain/kotlin/org/hyperledger/identus/apollo/derivation/EdHDKey.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ actual class EdHDKey actual constructor(
*/
actual fun initFromSeed(seed: ByteArray): EdHDKey {
require(seed.size == 64) {
"Seed expected byte length to be ${ECConfig.PRIVATE_KEY_BYTE_SIZE}"
"Seed expected byte length to be ${ECConfig.SEED_BYTE_SIZE}"
}

val keySlice = seed.sliceArray(0 until 32)
Expand Down
Loading