This repository was archived by the owner on Feb 1, 2024. It is now read-only.
Add RFC for State Pruning#8
Open
peterschwarz wants to merge 3 commits intohyperledger-archives:mainfrom
Open
Conversation
This RFC describes State Pruning, a necessary feature for long-term stability of the Sawtooth platform. It is a method for controlling growth of the state database by providing a mechanism for pruning older state roots in the Merkle-Radix state database. Signed-off-by: Peter Schwarz <pschwarz@bitwise.io>
peterschwarz
requested review from
TomBarnes,
agunde406,
aludvik,
dcmiddle,
jsmitchell and
vaporos
Signed-off-by: Peter Schwarz <pschwarz@bitwise.io>
agunde406
suggested changes
May 3, 2018
text/0008-state-pruning.md
Outdated
|
|
||
| Along side the serialized node, a change log for a particular state root is | ||
| stored. This change log includes the keys of values that are added, and keys of | ||
| deleted values by replaced by future state roots. The change log is written to |
Contributor
There was a problem hiding this comment.
"This change log includes the keys of values that are added, and keys of deleted values by replaced by future state roots." Im sure what you mean by "by replace by future state roots", is this a typo?
text/0008-state-pruning.md
Outdated
| Ethereum Geth has also discussed the use of state pruning for their Merkle trie | ||
| implemenation. It has not yet implemented this for its disk-based storage, but | ||
| it has implemented reference counting for its in-memory storage of the trie. See | ||
| this [blog post](https://blog.ethereum.org/2015/06/26/state-trie-pruning/) for |
Contributor
There was a problem hiding this comment.
This link does not work. I get a "Page not found"
|
|
||
| ## Configuration | ||
|
|
||
| Maximum block depth is a local configuration option. It is set via the command |
Contributor
There was a problem hiding this comment.
Will this be added to the validator.toml file as well? or only on the command line?
Contributor
Author
There was a problem hiding this comment.
Added some text for this.
- Addressed some typos. - Added a reference to the local configuration in the toml configuration, as well as CLI arguments. Signed-off-by: Peter Schwarz <pschwarz@bitwise.io>
agunde406
approved these changes
May 10, 2018
dcmiddle
approved these changes
May 11, 2018
text/0008-state-pruning.md
Outdated
|
|
||
| Along side the serialized node, a change log for a particular state root is | ||
| stored. This change log includes the keys of values that are added, and keys of | ||
| deleted values by replaced by future state roots. The change log is written to |
Contributor
There was a problem hiding this comment.
typo? "...by replaced by..."
jsmitchell
approved these changes
Apr 1, 2019
danintel
suggested changes
May 14, 2019
danintel
left a comment
danintel
left a comment
There was a problem hiding this comment.
A valuable feature--I am frequently asked about handling long-term blockchain growth and this will be useful.
There's some spelling errors that should be fixed.
| around when to switch from the pre-compacted to the post-compacted database. | ||
|
|
||
| See the | ||
| [documenation](http://www.lmdb.tech/doc/group__mdb.html#ga3bf50d7793b36aaddf6b481a44e24244) |
| [prior-art]: #prior-art | ||
|
|
||
| Ethereum Geth has also discussed the use of state pruning for their Merkle trie | ||
| implemenation. It has not yet implemented this for its disk-based storage, but |
| end of the copy, switch the reference to the underlying database for use in | ||
| normal operation and discard the old database. | ||
|
|
||
| This particular solution is simple in it's implementation, and requires no |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This RFC describes State Pruning, a necessary feature for long-term
stability of the Sawtooth platform. It is a method for controlling
growth of the state database by providing a mechanism for pruning older
state roots in the Merkle-Radix state database.
Signed-off-by: Peter Schwarz pschwarz@bitwise.io