Sketch Grids #127
Open
Sketch Grids #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonie-kramer
approved these changes
Dec 14, 2023
Contributor
anthonie-kramer
left a comment
anthonie-kramer
left a comment
There was a problem hiding this comment.
I think we should try to take advantage of RepresentationInstances where possible
Reviewed 23 of 23 files at r1, 16 of 16 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @katehryhorenko)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a function to Building Blocks called Sketch Grids. It enables a user to create grids by drawing lines. It also recognizes the faces of conceptual masses and creates grids along these faces by a user-configurable offset.
Building Blocks contains many functions that are used in Hypar examples and in the Hypar tour. Please ensure that that following are true before granting this PR.
hypar.jsonhave been translated to supported languages in themessagesfield.This change is