Make the facade go all the way up. #109
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikeough
commented
Jul 5, 2022
| envLevels.Insert(0, last); | ||
| } | ||
|
|
||
| if (envLevels.Last().Elevation != envelope.Height) |
Contributor
Author
There was a problem hiding this comment.
This is the change that matters. At some point we started using Levels to define the height of the facade and because we calculate the floor height by subtracting the next level height from the previous one, we don't get a top level height because we stop the iteration short of the level. We have to calculate the top level height as the distance between the last level and the top of the envelope.
cdriesler
approved these changes
Jul 6, 2022
Contributor
cdriesler
left a comment
cdriesler
left a comment
There was a problem hiding this comment.
Feels like we're getting closer and closer to when it's time to consolidate: "Envelope", "Levels", "Facade (Grid?)" ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The facade function does currently create a facade that covers the last level of the building. This PR fixes the facade function to create a facade that covers the entire height of the underlying envelope.
This applies only to the "Levels" function, not to the "Levels By Envelope" function.
Before:
After:
This change is