Skip to content

Comments

응원의 말 전송 기능 구현#35

Merged
hye-on merged 5 commits intomainfrom
feat/encouragement
Apr 2, 2025
Merged

응원의 말 전송 기능 구현#35
hye-on merged 5 commits intomainfrom
feat/encouragement

Conversation

@hye-on
Copy link
Owner

@hye-on hye-on commented Apr 2, 2025

🔗 관련 이슈

resolves #27

📝 작업 내용

  • 스케줄러를 사용하여 매일 오후11시에 응원의 말 전송하는 기능 구현
  • motivation-message엔티티에서 type삭제
    • ACHIEVEMENT응원 기능만 DB에 저장 (STREAK는 DB에 코멘트를 저장할 필요가 없고 DAILY문제 도착 알림은 필요가 없어짐)

📸 스크린샷

image

제일 마음에 드는 기능이다 🥺🐝🌸

@hye-on hye-on added the feature New feature or request label Apr 2, 2025
@hye-on hye-on requested a review from Copilot April 2, 2025 04:58
@hye-on hye-on self-assigned this Apr 2, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a daily encouragement message feature that automatically sends motivational content via a scheduler at 11 PM. It includes new repository, service, and scheduler components for handling encouragement messages, updates Discord message types and metadata accordingly, and adjusts migration scripts to remove the unused "type" field from motivation messages.

Reviewed Changes

Copilot reviewed 11 out of 14 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/modules/domain/motivation-message/motivation-message.repository.ts Adds repository logic to count and fetch motivation messages.
src/modules/domain/motivation-message/motivation-message.module.ts Registers the repository and service; note a potential typo in the service file name.
src/modules/domain/motivation-message/motivatioin-message.service.ts Provides a service to fetch a random motivation message with an edge-case return issue.
src/modules/domain/discord-message/discord-message.type.ts Updates Discord message types to include encouragement messages.
src/modules/core/scheduler/services/daily-encouragement.scheduler.ts Implements the scheduler to send daily encouragement messages to relevant channels.
src/modules/core/scheduler/scheduler.module.ts Integrates the new daily encouragement scheduler into the scheduling module.
src/database/types/motivation.type.ts & index.ts Removes the MotivationType enum which is no longer needed.
src/database/types/discord-message-metadate.ts Updates metadata types to include encouragement message details (file name may contain a typo).
src/database/migrations/Migration20250402015813.ts Adds migration steps to drop the "type" column from the motivation_messages table.
src/database/entities/motivation-message.entity.ts Removes the motivational type property from the entity.
Files not reviewed (3)
  • docker/init/01-schema.sql: Language not supported
  • docker/init/02-data.sql: Language not supported
  • src/database/migrations/.snapshot-saebom.json: Language not supported
Comments suppressed due to low confidence (1)

src/database/types/discord-message-metadate.ts:1

  • The filename 'discord-message-metadate.ts' appears to have a typographical error; consider renaming it to 'discord-message-metadata.ts' for clarity.
export type ProblemMetadata = {

@hye-on hye-on merged commit 8e14ba2 into main Apr 2, 2025
1 check passed
@hye-on hye-on deleted the feat/encouragement branch April 2, 2025 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

응원 기능

1 participant