Conversation
- `CommandHandler` 및 `CommandRegistry`의 역할 분리 - `listeners`와 `handlers`를 interaction폴더 아래 위치 - `InteractionListener`를 `SlashInteractionListenser`로 이름 수정
- cs, 복습, 새봄 채널 생성 - guild-creste 리스너, 핸들러 구현
- 스케줄러 사용 - 오늘 날짜 + 전체문제 숫자를 해싱함수에 넣어 오늘의 문제 선정하게 구현
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 관련 이슈
resovles: #12 #15
📝 작업 내용
🍇 고민한 부분
listener, handler를 interaction 폴더로 묶은 이유
이벤트를 감지하고 실행하는 흐름을 하나의 폴더에서 관리하여 응집도를 높이고, 유지보수성을 향상시킴.
listener와 handler를 분리한 이유
listener: 외부 디스코드 이벤트에 의존하는 부분을 분리하여 핸들러를 독립적으로 테스트 가능하게 만듦.
폴더 구조 개선
엔티티와 엔티티의 비즈니스 로직을 포함.
클린 아키텍처 20장: "업무 규칙은 수익을 창출하거나 비용을 줄이는 데 중요한 규칙 또는 절차."
ProblemService와DiscordGateway간 호출 구조 고민➡ Scheduler → ProblemService → DiscordGateway
➡
Scheduler->DailyProblemFacade-> (ProblemService,MessageService,DiscordGateway)➡ 채택:
Scheduler-> (ProblemService,DiscordGateway)🏃♀️ NEXT