Skip to content

Conversation

@aomrikti
Copy link
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings January 21, 2026 11:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements support for Appendix 14(2) (別表14(2)), which is a financial return statement for calculating deductible donation amounts. The implementation adds a new donation sub-account type for non-certified trusts and creates the complete logic and view template for generating this tax form.

Changes:

  • Added new sub-account code for "特定公益信託(認定外)" (Non-Certified Trust donations)
  • Implemented calculation logic for donation deduction limits across multiple donation categories
  • Created view template with detailed donation breakdowns and calculations

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
test/models/reports/appendix_14_02_logic_test.rb Adds comprehensive test coverage for the Appendix 14(2) logic including various donation types and detail calculations
test/data/sub_accounts.csv Adds test data entry for the new non-certified trust sub-account
test/data/journals.csv Adds test journal entries for different donation types to support testing
test/data/journal_details.csv Adds detailed journal entries linking donations to appropriate sub-accounts
db/schema.rb Updates schema version to reflect the new migration
db/migrate/20260119083638_insert_sub_account_600_for_8741_on_sub_accounts.rb Creates migration to add non-certified trust sub-account with proper up/down methods
config/first_boot/sub_accounts.csv Adds initial data for the new sub-account in first boot configuration
app/views/financial_return_statements/appendix_14_02/00000000.html.erb Implements the complete view template for rendering the Appendix 14(2) form with all required calculations and detail sections
app/utils/hyacc_const.rb Defines constants for the new report type and sub-account code
app/models/reports/appendix_14_02_logic.rb Implements core business logic for calculating donation deductions, including model classes and all calculation methods
app/controllers/base/view_attribute_handler.rb Registers the new report type in the available reports list

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants